Apply opam-specific git config if not full_fetch#6955
Open
sporkl wants to merge 1 commit into
Open
Conversation
`opam source --dev` should not apply opam-specific `git config`s. This commit adds a `will_full_fetch` argument to VCS.init, and only applies opam-specific git configurations when this is false. Also, default to full_fetch=false to mimic prior behavior.
Collaborator
|
Thanks for this first contribution! We'll try to take a look soon. For the moment we are trying to finalise 2.6 alpha release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opam source --devshould not apply opam-specificgit configs. This commit adds awill_full_fetchargument to VCS.init, and only applies opam-specific git configurations when this is false. Also, default to full_fetch=false to mimic prior behavior. This should resolve #6451 .I do have some failing tests locally, but it looks like the same tests fail on master for me.
Relatively new to contributing to open source, so any feedback is appreciated! I have a fair amount of free time these days, so looking to contribute more to the OCaml ecosystem.