Fix/tagged struct expr handling #67
Merged
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The catch-all IN clause handler was wrapping SubQuery expressions in
JSON_EACH(), producing invalid SQL like:
WHERE id IN (SELECT value FROM JSON_EACH(?))
This adds a specific pattern match for %Ecto.SubQuery{} before the
catch-all, generating proper inline subqueries:
WHERE id IN (SELECT s0.id FROM table AS s0 WHERE ...)
Also adds a general SubQuery expression handler that properly resolves
parent query aliases and combination queries.
This fixes compatibility with libraries like Oban that use subqueries
in UPDATE...WHERE id IN (subquery) patterns.
Ecto's query planner transforms {:type, _, [expr, type]} AST nodes
into %Ecto.Query.Tagged{} structs. The SQL generator only handled
the pre-planning tuple form, causing type-wrapped fragments (e.g.
type(fragment(...), :integer)) to fall through to the catch-all
expr clause which rendered a single '?' placeholder. This caused
parameter count mismatches with Hrana/Turso.
Fixes Oban Web JobQuery.limit_query crash on completed jobs page.
Contributor
WalkthroughThe update modifies internal logic in the Ecto LibSQL adapter to enhance SQL generation for Changes
Sequence Diagram(s)Skipped (diagram criteria not met, as only one file and no three-component interaction). Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ocean
added a commit
that referenced
this pull request
Jan 28, 2026
…67 Adds in_expression_comprehensive_test.exs to catch regressions in: 1. Issue #63: JSON encoding of list parameters in IN clauses - Simple list parameters should expand to individual placeholders - ~w() sigils should be handled via %Ecto.Query.Tagged{} detection 2. PR #66: Subqueries in IN expressions (Oban pattern) - WHERE id IN (SELECT ...) should generate proper SQL subquery - Before fix: incorrectly wrapped in JSON_EACH() causing malformed JSON error - After fix: generates inline subquery with correct aliases 3. PR #67: Tagged struct and type-wrapped expressions - Post-planning %Ecto.Query.Tagged{} nodes must be handled - Type-wrapped fragments should not fall through to catch-all '?' placeholder - Before fix: parameter count mismatch with Hrana/Turso - After fix: correct parameter count and proper type handling Tests include: - Basic list parameter expansion - Empty lists and single-element lists - ~w() sigil handling (Oban Lite pattern) - Multiple IN clauses combined - Subqueries with WHERE, SELECT, complex filters - Type-cast expressions - Integration tests combining multiple patterns All 15 tests pass with the fixes in place. Relates to: #63, PR #65, PR #66, PR #67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ecto's query planner transforms {:type, _, [expr, type]} AST nodes into %Ecto.Query.Tagged{} structs. The SQL generator only handled the pre-planning tuple form, causing type-wrapped fragments (e.g. type(fragment(...), :integer)) to fall through to the catch-all expr clause which rendered a single '?' placeholder. This caused parameter count mismatches with Hrana/Turso.
Fixes Oban Web JobQuery.limit_query crash on '$state' jobs page.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.