fix(osc): validate input ddl throw syntax exception when contain comment#1597
Merged
fix(osc): validate input ddl throw syntax exception when contain comment#1597
Conversation
krihy
added
type-bug
krihy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
module-online schema change
What this PR does / why we need it:
parse sql exception when when user input new ddl, so we remove comment before parse, case 1 and case 2 test passed.
case1:
origin sql:
ALTER TABLE "WUZHUJIANBIAO" MODIFY C2 VARCHAR2(20);-- some commentafter remove comment:
ALTER TABLE "WUZHUJIANBIAO" MODIFY C2 VARCHAR2(20);case 2:
origin sql:
ALTER TABLE "WUZHUJIANBIAO" MODIFY C2 VARCHAR2(20) -- some commentafter remove comment:
ALTER TABLE "WUZHUJIANBIAO" MODIFY C2 VARCHAR2(20) -- some commentWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: