Skip to content

fix(sql-check): failed to detect pk dropping when drop it as constraint#1879

Merged
yhilmare merged 3 commits intodev/4.2.xfrom
feat/shanlu_offline_ddl_detect
Mar 18, 2024
Merged

fix(sql-check): failed to detect pk dropping when drop it as constraint#1879
yhilmare merged 3 commits intodev/4.2.xfrom
feat/shanlu_offline_ddl_detect

Conversation

@yhilmare
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare commented Mar 13, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

primary key can be defined as a constraint, just like this:

create table abcd(
    id varchar2(64),
    constraint abcd primary key (id)
);

so that we can drop this pk by dropping constraint:

alter table abcd drop constraint abcd;

this pr consider of this situation~

Which issue(s) this PR fixes:

Fixes #1875 #1871 #1891 #1893 #1906

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label Mar 13, 2024
@yhilmare yhilmare added this to the ODC 4.2.4 milestone Mar 13, 2024
@yhilmare yhilmare self-assigned this Mar 13, 2024
PeachThinking
PeachThinking previously approved these changes Mar 13, 2024
Copy link
Copy Markdown
Contributor

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare linked an issue Mar 14, 2024 that may be closed by this pull request
@yhilmare yhilmare merged commit 286c1f0 into dev/4.2.x Mar 18, 2024
@yhilmare yhilmare deleted the feat/shanlu_offline_ddl_detect branch March 18, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

3 participants