Skip to content

fix(sql-check): avoid npe when virtual column exists#2031

Merged
yhilmare merged 1 commit intodev/4.2.xfrom
fix/shanlu_sql_check
Mar 25, 2024
Merged

fix(sql-check): avoid npe when virtual column exists#2031
yhilmare merged 1 commit intodev/4.2.xfrom
fix/shanlu_sql_check

Conversation

@yhilmare
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare commented Mar 25, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

the dataType is null when a column is a virtual column and it will lead to null pointer exception, this pr fix this problem.

Which issue(s) this PR fixes:

Fixes #2028

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label Mar 25, 2024
@yhilmare yhilmare added this to the ODC 4.2.4 milestone Mar 25, 2024
@yhilmare yhilmare self-assigned this Mar 25, 2024
@yhilmare yhilmare requested a review from PeachThinking as a code owner March 25, 2024 03:31
@yhilmare yhilmare linked an issue Mar 25, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit 58522cb into dev/4.2.x Mar 25, 2024
@yhilmare yhilmare deleted the fix/shanlu_sql_check branch March 25, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: Tables with virtual columns do not match sqlcheck detection

2 participants