Skip to content

fix(db-browser): remove spaces before and after ddl in oracle mode#2050

Merged
yhilmare merged 1 commit intodev/4.2.xfrom
fix/jingtian_424_remove_spaces_before_and_after_ddl
Mar 26, 2024
Merged

fix(db-browser): remove spaces before and after ddl in oracle mode#2050
yhilmare merged 1 commit intodev/4.2.xfrom
fix/jingtian_424_remove_spaces_before_and_after_ddl

Conversation

@PeachThinking
Copy link
Copy Markdown
Contributor

What type of PR is this?

type-bug

What this PR does / why we need it:

remove spaces before and after ddl of view and trigger in oracle mode

Which issue(s) this PR fixes:

Fixes #1954
Fixes #1907

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking added type-bug Something isn't working module-Database object Table/View/Type/Function/Procedure/Package/Synonym/Constraint/Index labels Mar 26, 2024
@PeachThinking PeachThinking added this to the ODC 4.2.4 milestone Mar 26, 2024
@PeachThinking PeachThinking self-assigned this Mar 26, 2024
@PeachThinking PeachThinking requested a review from yhilmare as a code owner March 26, 2024 03:15
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 5c09357 into dev/4.2.x Mar 26, 2024
@yhilmare yhilmare deleted the fix/jingtian_424_remove_spaces_before_and_after_ddl branch March 26, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module-Database object Table/View/Type/Function/Procedure/Package/Synonym/Constraint/Index type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants