Skip to content

fix(bastion): could not access SQL console when using OAuth for account integration#2253

Merged
yhilmare merged 7 commits intodev/4.2.xfrom
bugfix/gaoda_42x_fix_bastion_integration
Apr 22, 2024
Merged

fix(bastion): could not access SQL console when using OAuth for account integration#2253
yhilmare merged 7 commits intodev/4.2.xfrom
bugfix/gaoda_42x_fix_bastion_integration

Conversation

@smallsheeeep
Copy link
Copy Markdown
Contributor

What type of PR is this?

type-bug
module-bastion integration

What this PR does / why we need it:

When using Oauth for account integration, then can not using bastion integration for accessing a temp SQL console.

The root cause is that ODC must create a built-in project for user and then the bastion integration will work. But if user use Oauth for login, then the project will not be create.

In This PR, I fix it by create user related built-in project once the bastion integration is enbled.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


yhilmare
yhilmare previously approved these changes Apr 19, 2024
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ungreat
ungreat previously approved these changes Apr 19, 2024
Copy link
Copy Markdown
Collaborator

@ungreat ungreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smallsheeeep smallsheeeep dismissed stale reviews from ungreat and yhilmare via ddea283 April 19, 2024 03:23
@yhilmare yhilmare added this to the ODC 4.2.4-bp2 milestone Apr 19, 2024
Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit c4982c0 into dev/4.2.x Apr 22, 2024
@yhilmare yhilmare deleted the bugfix/gaoda_42x_fix_bastion_integration branch April 22, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot access SQL console when using both OAuth and bastion integration

4 participants