Skip to content

fix(flow): cancel pending task cause "Some tasks is not found"#2272

Merged
yhilmare merged 2 commits intodev/4.2.xfrom
yaobin_taskframework_fix_elements
Apr 23, 2024
Merged

fix(flow): cancel pending task cause "Some tasks is not found"#2272
yhilmare merged 2 commits intodev/4.2.xfrom
yaobin_taskframework_fix_elements

Conversation

@krihy
Copy link
Copy Markdown
Contributor

@krihy krihy commented Apr 22, 2024

What type of PR is this?

type-bug
module-flow

What this PR does / why we need it:

flowableAdaptor#getFlowableElementByType will return CALL_BACK task can cause Verify.verify(tasks.size() == elements.size()) exception, so filter CALL_BACK user task in getFlowableElementByType result

Which issue(s) this PR fixes:

cancel pending task which is timer execute cause "Some tasks is not found"

Special notes for your reviewer:

test passed

Additional documentation e.g., usage docs, etc.:


@krihy krihy added the type-bug Something isn't working label Apr 22, 2024
@krihy krihy added this to the ODC 4.2.4-bp2 milestone Apr 22, 2024
@krihy krihy self-assigned this Apr 22, 2024
@krihy krihy linked an issue Apr 22, 2024 that may be closed by this pull request
@krihy krihy marked this pull request as ready for review April 22, 2024 11:05
@krihy krihy requested a review from yhilmare as a code owner April 22, 2024 11:05
@krihy krihy changed the title fix(flow): fix cancel pending task verify exception fix(flow): cancel pending task cause "Some tasks is not found" Apr 22, 2024
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 39f5ae9 into dev/4.2.x Apr 23, 2024
@yhilmare yhilmare deleted the yaobin_taskframework_fix_elements branch April 23, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: Failed to terminate pending task

2 participants