Skip to content

enhancement(partition-plan): add a prompt when no preview sql generated#2351

Merged
yhilmare merged 3 commits intodev/4.2.xfrom
feat/shanlu_add_parti_prompt
May 10, 2024
Merged

enhancement(partition-plan): add a prompt when no preview sql generated#2351
yhilmare merged 3 commits intodev/4.2.xfrom
feat/shanlu_add_parti_prompt

Conversation

@yhilmare
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare commented May 9, 2024

What type of PR is this?

type-enhancement

What this PR does / why we need it:

add some prompt when no preview sql generated
截屏2024-05-09 20 56 52
截屏2024-05-09 20 57 23

Which issue(s) this PR fixes:

Fixes #2345

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label May 9, 2024
@yhilmare yhilmare added this to the ODC 4.2.4-bp2 milestone May 9, 2024
@yhilmare yhilmare self-assigned this May 9, 2024
@yhilmare yhilmare requested review from guowl3 and yizhouxw as code owners May 9, 2024 13:00
@yhilmare yhilmare requested a review from krihy as a code owner May 9, 2024 14:09
@yhilmare yhilmare linked an issue May 9, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Collaborator

@guowl3 guowl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@krihy krihy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 5a40493 into dev/4.2.x May 10, 2024
@yhilmare yhilmare deleted the feat/shanlu_add_parti_prompt branch May 10, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: The parentheses for database changes are in English

4 participants