Conversation
yhilmare
reviewed
May 11, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/websocket/OBClientReadThread.java
Show resolved
Hide resolved
yizhouxw
previously approved these changes
May 13, 2024
Contributor
yizhouxw
left a comment
yizhouxw
left a comment
There was a problem hiding this comment.
lgtm,
current only windows/linux support command line windows,
windows user \r\n, linux use \n as line separator, but windows is compatible with \n also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
When input a long sequence in obclient, it would return a sequence with
\rin it. And it would cause the cursor going back to head of the line .So we replace these unexpected characters manually.
Which issue(s) this PR fixes:
Fixes #2301