Skip to content

fix(iam): failed to delete a user who is an archived project's Owner or DBA#2359

Merged
yhilmare merged 5 commits intodev/4.2.xfrom
yizhuo_424bp2_fix_delete_user_failed
May 13, 2024
Merged

fix(iam): failed to delete a user who is an archived project's Owner or DBA#2359
yhilmare merged 5 commits intodev/4.2.xfrom
yizhuo_424bp2_fix_delete_user_failed

Conversation

@yiminpeng
Copy link
Copy Markdown
Collaborator

@yiminpeng yiminpeng commented May 10, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

If the user joins a project that has been archived, deleting the user fails.
PS: Only when the user is the admin/DBA of the project will it not be deleted.

Which issue(s) this PR fixes:

Fixes #2284

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

@yiminpeng yiminpeng added the type-bug Something isn't working label May 10, 2024
@yiminpeng yiminpeng added this to the ODC 4.2.4-bp2 milestone May 10, 2024
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on submitting your first PR!

Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title suggestion: fix(iam): failed to delete a user who is an archived project's Owner or DBA

@yhilmare yhilmare changed the title fix(iam): Failed to delete a user associated with an archived project fix(iam): failed to delete a user associated with an archived project May 11, 2024
@yiminpeng yiminpeng changed the title fix(iam): failed to delete a user associated with an archived project fix(iam): failed to delete a user who is an archived project's Owner or DBA May 13, 2024
Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 5b284bd into dev/4.2.x May 13, 2024
@yhilmare yhilmare deleted the yizhuo_424bp2_fix_delete_user_failed branch May 13, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority-high type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants