Skip to content

fix(notification): DLM events were missed when task framework not enabled#2445

Merged
yhilmare merged 2 commits intodev/4.3.0from
wenmu_430_fix_notification_miss_without_taskframework
May 21, 2024
Merged

fix(notification): DLM events were missed when task framework not enabled#2445
yhilmare merged 2 commits intodev/4.3.0from
wenmu_430_fix_notification_miss_without_taskframework

Conversation

@LuckyPickleZZ
Copy link
Copy Markdown
Member

What type of PR is this?

type-bug

What this PR does / why we need it:

When task framework is not enabled, the DLM jobs' event would not be created.

Which issue(s) this PR fixes:

Fixes #2335

@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.3.0 milestone May 21, 2024
@LuckyPickleZZ LuckyPickleZZ self-assigned this May 21, 2024
Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@guowl3 guowl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 67fccf2 into dev/4.3.0 May 21, 2024
@yhilmare yhilmare deleted the wenmu_430_fix_notification_miss_without_taskframework branch May 21, 2024 12:31
@LuckyPickleZZ LuckyPickleZZ restored the wenmu_430_fix_notification_miss_without_taskframework branch July 24, 2024 09:01
@LuckyPickleZZ LuckyPickleZZ deleted the wenmu_430_fix_notification_miss_without_taskframework branch July 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants