Skip to content

fix(web): cannot return a page with more than 2000 records#2520

Merged
yhilmare merged 2 commits intodev/4.3.0from
lebie_430_fix_pagable
May 29, 2024
Merged

fix(web): cannot return a page with more than 2000 records#2520
yhilmare merged 2 commits intodev/4.3.0from
lebie_430_fix_pagable

Conversation

@MarkPotato777
Copy link
Copy Markdown
Contributor

What type of PR is this?

type-bug

What this PR does / why we need it:

Spring sets a default max page size of 2000 which means that if the front-end requests for a more than 2000 page size, the backend will return only 2000 records in one page.
This PR adjusts the default value 2000 to 99999.

Which issue(s) this PR fixes:

Fixes #2446

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@MarkPotato777 MarkPotato777 added the type-bug Something isn't working label May 28, 2024
@MarkPotato777 MarkPotato777 added this to the ODC 4.3.0 milestone May 28, 2024
@MarkPotato777 MarkPotato777 self-assigned this May 28, 2024
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare changed the title fix(web): cannot return a page with more than 2000 records. fix(web): cannot return a page with more than 2000 records May 28, 2024
Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 306b89f into dev/4.3.0 May 29, 2024
@yhilmare yhilmare deleted the lebie_430_fix_pagable branch May 29, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants