Skip to content

fix(schedule): schedule cannot be disabled if project is archived#2562

Merged
yhilmare merged 3 commits intodev/4.3.0from
tianke_430_fix_schedule_cannot_be_disable
Jun 3, 2024
Merged

fix(schedule): schedule cannot be disabled if project is archived#2562
yhilmare merged 3 commits intodev/4.3.0from
tianke_430_fix_schedule_cannot_be_disable

Conversation

@guowl3
Copy link
Copy Markdown
Collaborator

@guowl3 guowl3 commented May 29, 2024

What type of PR is this?

What this PR does / why we need it:

Added validation to prevent archiving the project if any enabled schedules exist.

Which issue(s) this PR fixes:

Fixes #2180

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@guowl3 guowl3 added the type-bug Something isn't working label May 29, 2024
@guowl3 guowl3 added this to the ODC 4.3.0 milestone May 29, 2024
@guowl3 guowl3 self-assigned this May 29, 2024
yizhouxw
yizhouxw previously approved these changes May 31, 2024
Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 30507de into dev/4.3.0 Jun 3, 2024
@yhilmare yhilmare deleted the tianke_430_fix_schedule_cannot_be_disable branch June 3, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants