Skip to content

fix(ticket): wrong i18n description for task#2579

Merged
yhilmare merged 2 commits intodev/4.3.0from
bugfix/gaoda_430_fix_task_description
May 30, 2024
Merged

fix(ticket): wrong i18n description for task#2579
yhilmare merged 2 commits intodev/4.3.0from
bugfix/gaoda_430_fix_task_description

Conversation

@smallsheeeep
Copy link
Copy Markdown
Contributor

What type of PR is this?

type-bug
module-i18n, ticket

What this PR does / why we need it:

The task created by Scheduler has wrong locale context. And then the task description generated by DescriptionGenerator is wrong.
This PR fix it by using i18n key replace using actual characters.

Which issue(s) this PR fixes:

Fixes #2345

Special notes for your reviewer:

Self-test Passed.
image

Additional documentation e.g., usage docs, etc.:


@smallsheeeep smallsheeeep added the type-bug Something isn't working label May 30, 2024
@smallsheeeep smallsheeeep added this to the ODC 4.3.0 milestone May 30, 2024
@smallsheeeep smallsheeeep requested a review from guowl3 May 30, 2024 07:31
@smallsheeeep smallsheeeep self-assigned this May 30, 2024
@smallsheeeep smallsheeeep linked an issue May 30, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 703badf into dev/4.3.0 May 30, 2024
@yhilmare yhilmare deleted the bugfix/gaoda_430_fix_task_description branch May 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: The parentheses for database changes are in English

2 participants