Skip to content

fix(flow-task): optimize error message of flow task cancelation#2624

Merged
yhilmare merged 1 commit intodev/4.3.0from
wenmu_430_fix_optimize_cancelled_error_message
Jun 4, 2024
Merged

fix(flow-task): optimize error message of flow task cancelation#2624
yhilmare merged 1 commit intodev/4.3.0from
wenmu_430_fix_optimize_cancelled_error_message

Conversation

@LuckyPickleZZ
Copy link
Copy Markdown
Member

What type of PR is this?

type-bug

What this PR does / why we need it:

When cancel a database change task, if this task is not started yet, there may be an error 'RollBack task can not be cancelled'. This error message is confusing, we should optimize it.

Which issue(s) this PR fixes:

Fixes #2418

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@LuckyPickleZZ LuckyPickleZZ added the type-bug Something isn't working label Jun 3, 2024
@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.3.0 milestone Jun 3, 2024
@LuckyPickleZZ LuckyPickleZZ self-assigned this Jun 3, 2024
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit e024cb9 into dev/4.3.0 Jun 4, 2024
@yhilmare yhilmare deleted the wenmu_430_fix_optimize_cancelled_error_message branch June 4, 2024 02:29
@LuckyPickleZZ LuckyPickleZZ restored the wenmu_430_fix_optimize_cancelled_error_message branch July 24, 2024 09:01
@LuckyPickleZZ LuckyPickleZZ deleted the wenmu_430_fix_optimize_cancelled_error_message branch July 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants