fix(schema): loading table detail costs too much time#2626
Merged
fix(schema): loading table detail costs too much time#2626
Conversation
yizhouxw
approved these changes
Jun 3, 2024
Contributor
yizhouxw
left a comment
yizhouxw
left a comment
There was a problem hiding this comment.
how! so much improvement!
Contributor
Author
😂This performance improvement is tested based on user examples and is not universal. |
PeachThinking
approved these changes
Jun 4, 2024
libs/db-browser/src/main/java/com/oceanbase/tools/dbbrowser/parser/PLParser.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
we parse table's ddl too many times which is not necessary, I add a cache to let a ddl only be parsed once.
the time consuming reduced by 90% (20s+ -> 1.44s)
Which issue(s) this PR fixes:
Fixes #2440
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: