Skip to content

fix(multiple database): added exclusive description of the subticket #2762

Merged
yhilmare merged 8 commits intodev/4.3.0from
fix/zijia_add_description_of_subticket
Jun 19, 2024
Merged

fix(multiple database): added exclusive description of the subticket #2762
yhilmare merged 8 commits intodev/4.3.0from
fix/zijia_add_description_of_subticket

Conversation

@zijiacj
Copy link
Copy Markdown
Collaborator

@zijiacj zijiacj commented Jun 17, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

Add a style-specific description of a child ticket for a multi-database change. Converts other types of tickets' descriptions from I18N to L10N
image

Which issue(s) this PR fixes:

Fixes #2744

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@zijiacj zijiacj added the type-bug Something isn't working label Jun 17, 2024
@zijiacj zijiacj added this to the ODC 4.3.0-bp1 milestone Jun 17, 2024
@zijiacj zijiacj self-assigned this Jun 17, 2024
@zijiacj zijiacj marked this pull request as draft June 17, 2024 14:25
@zijiacj zijiacj marked this pull request as ready for review June 18, 2024 04:16
Jane201510
Jane201510 previously approved these changes Jun 18, 2024
krihy
krihy previously approved these changes Jun 18, 2024
Copy link
Copy Markdown
Contributor

@krihy krihy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zijiacj zijiacj force-pushed the fix/zijia_add_description_of_subticket branch from 65daa3b to e812e43 Compare June 18, 2024 23:36
yizhouxw
yizhouxw previously approved these changes Jun 19, 2024
Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zijiacj zijiacj requested a review from krihy June 19, 2024 06:05
yhilmare
yhilmare previously approved these changes Jun 19, 2024
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

LuckyPickleZZ
LuckyPickleZZ previously approved these changes Jun 19, 2024
smallsheeeep
smallsheeeep previously approved these changes Jun 19, 2024
Copy link
Copy Markdown
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

krihy
krihy previously approved these changes Jun 19, 2024
Copy link
Copy Markdown
Contributor

@krihy krihy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

LuckyPickleZZ
LuckyPickleZZ previously approved these changes Jun 19, 2024
Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 2e7a394 into dev/4.3.0 Jun 19, 2024
@yhilmare yhilmare deleted the fix/zijia_add_description_of_subticket branch June 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants