Skip to content

fix(data-transfer): avoid task failure by processing exception messages#2779

Merged
yhilmare merged 2 commits intodev/4.3.0from
wenmu_430_fix_transfer_exception_optimize
Jun 20, 2024
Merged

fix(data-transfer): avoid task failure by processing exception messages#2779
yhilmare merged 2 commits intodev/4.3.0from
wenmu_430_fix_transfer_exception_optimize

Conversation

@LuckyPickleZZ
Copy link
Copy Markdown
Member

What type of PR is this?

type-bug

What this PR does / why we need it:

Sometimes ob-loader-dumper's error messages are confusing.

  1. If we catch an exception 'No subfiles are generated from path', it's because all the data files are empty. In this case , the task state should not be failed.
  2. If we catch an exception 'table or view does not exist', This may be because the user lacks query permissions for the DBA view. We could give users a prompt in the log.

Which issue(s) this PR fixes:

Fixes #2774

@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.3.0-bp1 milestone Jun 19, 2024
@LuckyPickleZZ LuckyPickleZZ requested a review from yizhouxw June 19, 2024 06:31
@LuckyPickleZZ LuckyPickleZZ self-assigned this Jun 19, 2024
@LuckyPickleZZ LuckyPickleZZ requested a review from yhilmare as a code owner June 19, 2024 06:31
Copy link
Copy Markdown
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit cb97f07 into dev/4.3.0 Jun 20, 2024
@yhilmare yhilmare deleted the wenmu_430_fix_transfer_exception_optimize branch June 20, 2024 02:26
@LuckyPickleZZ LuckyPickleZZ restored the wenmu_430_fix_transfer_exception_optimize branch July 24, 2024 09:01
@LuckyPickleZZ LuckyPickleZZ deleted the wenmu_430_fix_transfer_exception_optimize branch July 24, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants