Skip to content

Comments

fix(collaboration): databases' environment have not been updated after the datasource's environment changed#3695

Merged
yizhouxw merged 1 commit intodev/4.3.2_bp1from
lebie_432bp1_1016_1
Oct 16, 2024
Merged

fix(collaboration): databases' environment have not been updated after the datasource's environment changed#3695
yizhouxw merged 1 commit intodev/4.3.2_bp1from
lebie_432bp1_1016_1

Conversation

@MarkPotato777
Copy link
Contributor

What type of PR is this?

type-bug

What this PR does / why we need it:

Fix the PR #3688 , wrong order of the parameters passing to the method.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@MarkPotato777 MarkPotato777 added the type-bug Something isn't working label Oct 16, 2024
@MarkPotato777 MarkPotato777 added this to the ODC 4.3.2-bp1 milestone Oct 16, 2024
@MarkPotato777 MarkPotato777 self-assigned this Oct 16, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yizhouxw yizhouxw merged commit 1b91b0f into dev/4.3.2_bp1 Oct 16, 2024
@yizhouxw yizhouxw deleted the lebie_432bp1_1016_1 branch October 16, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug Something isn't working

Projects

Status: Developed

Development

Successfully merging this pull request may close these issues.

3 participants