Skip to content

refactor: remove unused check_os_params (#14)#125

Merged
hnwyllmm merged 1 commit intooceanbase:developfrom
Rynzie02:delete-check_os_params
Feb 9, 2026
Merged

refactor: remove unused check_os_params (#14)#125
hnwyllmm merged 1 commit intooceanbase:developfrom
Rynzie02:delete-check_os_params

Conversation

@Rynzie02
Copy link
Copy Markdown
Contributor

Task Description

close #14

Solution Description

Delete check_os_params implementation

Passed Regressions

ctest: 96% tests passed(303/317).

The failed test cases are not directly related to the changes in this PR.

96% tests passed, 14 tests failed out of 317

Total Test time (real) = 2541.24 sec

The following tests FAILED:
         18 - test_raw_expr_resolver (Failed)
        120 - test_backup_extern_info_mgr (ILLEGAL)
        144 - test_protected_memtable_mgr_handle (Subprocess aborted)
        224 - test_create_executor (Subprocess aborted)
        234 - test_uniq_task_queue (SEGFAULT)
        240 - test_storage_file (ILLEGAL)
        249 - test_ob_future (ILLEGAL)
        254 - test_geo_bin (Subprocess aborted)
        257 - test_wkt_parser (Failed)
        259 - test_geo_tree (Subprocess aborted)
        262 - test_geo_func_difference (Subprocess aborted)
        263 - test_geo_func_union (Subprocess aborted)
        269 - test_json_base (Failed)
        297 - test_vsag_adaptor (Timeout)

Upgrade Compatibility

Keep the configuration option strict_check_os_params for backward compatibility, but mark it as deprecated so that existing configuration files or scripts continue to work without causing any functional behavior changes.

Other Information

Release Note

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the unused check_os_params functionality from the codebase. The OS parameter checking logic was intended to verify system configuration requirements but has proven too strict in practice and is no longer used. The PR maintains backward compatibility by keeping the strict_check_os_params configuration parameter but marking it as deprecated.

Changes:

  • Removed check_os_params implementation files (header and source)
  • Removed related unit test file and build configurations
  • Removed the function call from server initialization
  • Deprecated the strict_check_os_params configuration parameter for backward compatibility

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/observer/ob_check_params.h Deleted header file containing CheckAllParams class and check_os_params function declarations
src/observer/ob_check_params.cpp Deleted implementation file with OS parameter validation logic (376 lines)
unittest/observer/test_check_os_params.cpp Deleted unit test file for the removed functionality
src/observer/ob_server.cpp Removed include directive and check_os_params function call from server initialization
src/observer/CMakeLists.txt Removed ob_check_params.cpp from build configuration
unittest/observer/CMakeLists.txt Removed test_check_os_params from test build configuration
src/share/parameter/ob_parameter_seed.ipp Updated strict_check_os_params parameter with deprecation notice and clarified it has no effect

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@LINxiansheng LINxiansheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LINxiansheng
Copy link
Copy Markdown
Member

plz fix your conflict

@LINxiansheng
Copy link
Copy Markdown
Member

Do not worry about the coding activity, I marked your merged.

@Rynzie02 Rynzie02 force-pushed the delete-check_os_params branch from a8e1fb7 to 1c45883 Compare February 2, 2026 05:23
@Rynzie02
Copy link
Copy Markdown
Contributor Author

Rynzie02 commented Feb 2, 2026

@LINxiansheng @hnwyllmm Hi, I‘ve fixed the conflict. Please check.
And, I also noticed that when running unit tests on my local machine (Ubuntu 24.04, physical host), some tests are failing:

97% tests passed, 10 tests failed out of 317

Total Test time (real) = 2474.84 sec

The following tests FAILED:
         18 - test_raw_expr_resolver (Failed)
        144 - test_protected_memtable_mgr_handle (Subprocess aborted)
        224 - test_create_executor (Subprocess aborted)
        248 - test_ob_occam_thread_pool (Failed)
        254 - test_geo_bin (Subprocess aborted)
        257 - test_wkt_parser (Failed)
        259 - test_geo_tree (Subprocess aborted)
        262 - test_geo_func_difference (Subprocess aborted)
        263 - test_geo_func_union (Subprocess aborted)
        269 - test_json_base (Failed)
Errors while running CTest
Output from these tests are in: /home/rynzie/Proj/db/ob_seekdb/build_debug/unittest/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.

When I opened this PR, I ran unit tests on a virtual machine(Ubuntu24.04) as well, and observed similar failures:

Passed Regressions
ctest: 96% tests passed(303/317).
The failed test cases are not directly related to the changes in this PR.
96% tests passed, 14 tests failed out of 317
Total Test time (real) = 2541.24 sec
The following tests FAILED:
18 - test_raw_expr_resolver (Failed)
120 - test_backup_extern_info_mgr (ILLEGAL)
144 - test_protected_memtable_mgr_handle (Subprocess aborted)
224 - test_create_executor (Subprocess aborted)
234 - test_uniq_task_queue (SEGFAULT)
240 - test_storage_file (ILLEGAL)
249 - test_ob_future (ILLEGAL)
254 - test_geo_bin (Subprocess aborted)
257 - test_wkt_parser (Failed)
259 - test_geo_tree (Subprocess aborted)
262 - test_geo_func_difference (Subprocess aborted)
263 - test_geo_func_union (Subprocess aborted)
269 - test_json_base (Failed)
297 - test_vsag_adaptor (Timeout)

So the failing cases are reproducible on both my virtual machine and physical machine, and do not appear to be environment-specific.

Could you please help check whether these failures can be reproduced on your side?

Let me know if you’d like me to open a separate issue and/or submit an additional PR to address these test failures.

@Rynzie02 Rynzie02 force-pushed the delete-check_os_params branch from 1c45883 to d576c11 Compare February 3, 2026 02:20
@Rynzie02
Copy link
Copy Markdown
Contributor Author

Rynzie02 commented Feb 9, 2026

@LINxiansheng @hnwyllmm I've addressed the feedback and updated the PR.
Whenever you have time, could you please take another look? Thanks!

@hnwyllmm hnwyllmm merged commit 05f33fb into oceanbase:develop Feb 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

delete code check_os_params

4 participants