fix: use to_show_str for session sys vars#132
Merged
LINxiansheng merged 2 commits intooceanbase:developfrom Jan 31, 2026
Merged
fix: use to_show_str for session sys vars#132LINxiansheng merged 2 commits intooceanbase:developfrom
LINxiansheng merged 2 commits intooceanbase:developfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
close #107
Solution Description
In the system variable encoding logic within the OK packet construction path, change the direct conversion of internal numerical IDs to calling the to_show_str() function to ensure that the character set/collation name strings sent to the client comply with the MySQL protocol specifications.
Passed Regressions
Unittest, Manual testing
