add existing dir warning and how to fix it#187
Merged
ocefpaf merged 3 commits intooceanhackweek:sourcefrom Aug 11, 2022
ocefpaf:returnig_folks_nbgitpuller_issue
Merged
add existing dir warning and how to fix it#187ocefpaf merged 3 commits intooceanhackweek:sourcefrom ocefpaf:returnig_folks_nbgitpuller_issue
ocefpaf merged 3 commits intooceanhackweek:sourcefrom
ocefpaf:returnig_folks_nbgitpuller_issue
Conversation
✅ Deploy Preview for oceanhackweek-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
abkfenris
reviewed
Aug 11, 2022
emiliom
reviewed
Aug 11, 2022
Member
|
@ocefpaf I think your edits looked fine. I've made a couple of small suggestions. Combined with @abkfenris 's suggestion, I think it's good to go. A little verbose, but I don't know how to cut it down. |
Co-authored-by: Alex Kerney <abk@mac.com>
Co-authored-by: Emilio Mayorga <emiliomayorga@gmail.com>
Member
Author
Same :-/ Let's revisit this when OHW is done. We can probably break it up into smaller phrases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@emiliom and @abkfenris I'm not 100% happy with my edits. Any suggestions on how we can make that warning informative but not too complicated?