Skip to content

Bake theme#44

Merged
emiliom merged 5 commits intooceanhackweek:masterfrom
ocefpaf:bake_theme
Mar 7, 2020
Merged

Bake theme#44
emiliom merged 5 commits intooceanhackweek:masterfrom
ocefpaf:bake_theme

Conversation

@ocefpaf
Copy link
Copy Markdown
Member

@ocefpaf ocefpaf commented Mar 7, 2020

@emiliom this PR does not change anything in the website nor it updates the theme. It is just an exercise to "bake" the theme submodule into the site there to see if things will be easier to edit/update.

One can install jekyll locally with:

conda create --name JEKYLL rb-bundler compilers
conda activate JEKYLL
bundle install

and then type:

bundle exec jekyll serve

to build and serve the site at http://127.0.0.1:4000/.

Commit 8ab2f4f is massive b/c it brings the whole submodule theme to this repo.

Comment thread _config.yml

# Submodule setting
# Theme setting, we are excluding jekyll-spectral-theme/ root to avoid picking up theme config.
# We should probably clean it up later.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exclude here is to ignore some configs from the upstream submodule. We could just remove those file latest b/c they are related to the geohackweek.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Removing "later" (I assume that's what you meant to say?) sounds good.

@ocefpaf ocefpaf mentioned this pull request Mar 7, 2020
@emiliom
Copy link
Copy Markdown
Member

emiliom commented Mar 7, 2020

Thanks @ocefpaf!

@leewujung or @amanda-tan could you merge this PR, please? I just realized I'm not an admin no the OHW github org, yet. I messaged you about that on Slack.

Thanks!

@emiliom emiliom mentioned this pull request Mar 7, 2020
@emiliom emiliom merged commit da1aa7c into oceanhackweek:master Mar 7, 2020
@ocefpaf ocefpaf deleted the bake_theme branch March 8, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants