Bake theme#44
Merged
emiliom merged 5 commits intooceanhackweek:masterfrom Mar 7, 2020
ocefpaf:bake_theme
Merged
Conversation
ocefpaf
commented
Mar 7, 2020
|
|
||
| # Submodule setting | ||
| # Theme setting, we are excluding jekyll-spectral-theme/ root to avoid picking up theme config. | ||
| # We should probably clean it up later. |
Member
Author
There was a problem hiding this comment.
The exclude here is to ignore some configs from the upstream submodule. We could just remove those file latest b/c they are related to the geohackweek.
Member
There was a problem hiding this comment.
Sure. Removing "later" (I assume that's what you meant to say?) sounds good.
Closed
Member
|
Thanks @ocefpaf! @leewujung or @amanda-tan could you merge this PR, please? I just realized I'm not an admin no the OHW github org, yet. I messaged you about that on Slack. Thanks! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@emiliom this PR does not change anything in the website nor it updates the theme. It is just an exercise to "bake" the theme submodule into the site there to see if things will be easier to edit/update.
One can install jekyll locally with:
and then type:
to build and serve the site at
http://127.0.0.1:4000/.Commit 8ab2f4f is massive b/c it brings the whole submodule theme to this repo.