Add challenge DF into active rewards workflow#657
Merged
Conversation
calina-c
suggested changes
Jun 29, 2023
calina-c
suggested changes
Jun 29, 2023
calina-c
approved these changes
Jul 3, 2023
Contributor
|
@trizin I got this up to date and ready to merge (merged main, resolved all conversations etc.) but I will wait for you to merge it. |
idiom-bytes
reviewed
Jul 20, 2023
idiom-bytes
reviewed
Jul 21, 2023
idiom-bytes
approved these changes
Jul 21, 2023
Member
idiom-bytes
left a comment
idiom-bytes
left a comment
There was a problem hiding this comment.
Looks good, thanks for the tests!
|
Code Climate has analyzed commit c9b512d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.8% (90% is the threshold). This pull request will bring the total coverage in the repository to 94.6% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #656
Changes proposed in this PR: