Skip to content

Fix #684: Generate predictoor data in active rewards workflow [merge once deployed to Sapphire mainnet]#685

Merged
trizin merged 12 commits intomainfrom
issue684-generate-predictoor-data-in-active-reward-distribution
Oct 11, 2023
Merged

Fix #684: Generate predictoor data in active rewards workflow [merge once deployed to Sapphire mainnet]#685
trizin merged 12 commits intomainfrom
issue684-generate-predictoor-data-in-active-reward-distribution

Conversation

@trizin
Copy link
Copy Markdown
Contributor

@trizin trizin commented Jul 21, 2023

Fixes #684

Changes proposed in this PR:

  • Generate predictoor data in active rewards workflow
  • Fix help message

@trizin trizin linked an issue Jul 21, 2023 that may be closed by this pull request
Generate Predictoor data in active reward distribution #684
Closed
2 tasks
@trizin trizin marked this pull request as ready for review July 21, 2023 11:35
@trizin trizin added Status: DoNotMerge Status: Blocked Blocked by dependency, platform requirement, etc (add comment to detail the reason) labels Jul 21, 2023
@trizin trizin marked this pull request as draft August 1, 2023 13:51
@trentmc
Copy link
Copy Markdown
Member

trentmc commented Aug 19, 2023 •
edited
Loading

@trizin why is this PR labeled as "blocked"? ie what prevents us from merging this PR into main branch?

@trizin
Copy link
Copy Markdown
Contributor Author

trizin commented Aug 19, 2023

This PR adds fetching predictoor data from Sapphire mainnet and uploading it to gbucket as a part of active reward distribution workflow. Sapphire mainnet deployment isn't done.

@trentmc trentmc changed the title Generate predictoor data in active rewards workflow Generate predictoor data in active rewards workflow [merge once deployed to Saphhire mainnet] Aug 19, 2023
@trentmc
Copy link
Copy Markdown
Member

trentmc commented Aug 19, 2023

This PR adds fetching predictoor data from Sapphire mainnet and uploading it to gbucket as a part of active reward distribution workflow. Sapphire mainnet deployment isn't done.

Perfect, thanks. I've updated the title accordingly, to make it obvious when to merge.

@trentmc trentmc changed the title Generate predictoor data in active rewards workflow [merge once deployed to Saphhire mainnet] Fix #648: Generate predictoor data in active rewards workflow [merge once deployed to Saphhire mainnet] Aug 19, 2023
@trentmc trentmc changed the title Fix #648: Generate predictoor data in active rewards workflow [merge once deployed to Saphhire mainnet] Fix #684: Generate predictoor data in active rewards workflow [merge once deployed to Saphhire mainnet] Aug 19, 2023
@trizin trizin marked this pull request as ready for review October 6, 2023 16:18
@trizin trizin marked this pull request as draft October 6, 2023 16:19
@trentmc trentmc changed the title Fix #684: Generate predictoor data in active rewards workflow [merge once deployed to Saphhire mainnet] Fix #684: Generate predictoor data in active rewards workflow [merge once deployed to Sapphire mainnet] Oct 10, 2023
trizin added 2 commits October 10, 2023 17:12
@trizin
#715 - Support predictoor assets (#722)
a342477 
* Formatting

* Fix predictoor subgraph query

* Add deployer addresses

* Make staking optional

* Custom filtering logic for predictoor contracts

* Formatting

* Update address.json

* Update active reward flow

* Formatting

* Formatting

* Use timestamp in dftool predictoor data

* Use timestamp for predictoor data and other fixes

* Formatting

* Trigger Build

* Fix linter issues

* Fix mypy issue

* Fix test

* Update queries.py
@trizin
Update naming
c917635
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy bot commented Oct 10, 2023

Code Climate has analyzed commit c917635 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 42.8% (90% is the threshold).

This pull request will bring the total coverage in the repository to 93.3% (-0.4% change).

View more on Code Climate.

@trizin trizin marked this pull request as ready for review October 11, 2023 22:32
@trizin trizin merged commit 3aaef4b into main Oct 11, 2023
@trizin trizin deleted the issue684-generate-predictoor-data-in-active-reward-distribution branch October 11, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Priority: Low Status: Blocked Blocked by dependency, platform requirement, etc (add comment to detail the reason) Status: DoNotMerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate Predictoor data in active reward distribution

2 participants

@trizin @trentmc