Use env var "BINANCE_API_URL" instead of harcoded url#718
Merged
Conversation
trizin
changed the title
|
Code Climate has analyzed commit 9bf4e65 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.7% (0.0% change). View more on Code Climate. |
trentmc
approved these changes
Oct 5, 2023
calina-c
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Use api.binance * Update url * Fix * Assign env var
trizin
added a commit
that referenced
this pull request
Nov 2, 2023
* Initial commit - conftest working. * Intermediary commit. * Adds contract deployment. * Remove more ocurrences in tests. * Fix dftool challenge tests. * More corrections. * More fixes for pytest error collection. * More test fixes. * Fixes to ve tests. * More fixes to test collection and add function for chain id to web3. * Fix first df module test. * More df module fixes. * Fix dftool challenge tests. * Fix oceanutil. * Fix mine command. * More test fixes. * More dftool fixes. * More corrections. * More fixes. * Fix time utils. * More fixes. * More checksums. * More fixes. * Apply isort and black. * Adapt test flow. * Adds built contracts from gitignore. * Fix setup function for dftool test. * Automit in setup. * Remove goerly setup function. * Unify account fixtures. * First step of using contracts from the chain explicitly. * More minor fixes. * Intermediary commit. * Adds more chain injection, remove chain parameter where range is present. * Fixes to chain id injection. * Remove veOCEAN deployment. * Partially improve test_queries. * Remove some unneeded tests. * Revert some previous chain id changes. * Use env var "BINANCE_API_URL" instead of harcoded url (#718) * Use api.binance * Update url * Fix * Assign env var * Fix dispense passive test. * A small test fix. * Fix dispense tests. * More removals of Brownie. * More removal of brownie ocurrences. * Fix infura connection logic. * Vesting calc changes. * Some fixes to df strategy commands. * Remove todos with to_weis from test Simpletoken. * Fixed new functions commands and tests. * Isort, black and other cosmetic changes. * Fix Simpletoken tests TODOs. * More TODO removals. * More TODO removals. * Fix allocation sampling test. * Small fix to ve delegation. * Fix vesting schedule test. * Fixes DFRewards test. * Adapt test-dfsql flow. * Fixes. * Partially fix mypy. * More linter fixes.g * More mypy linter complaint fixes. * More mypy fixes. * More linter fixes. * Adapt all other CI flows.g * Finish iteration with linter errors. * Add underscore instead of dash to sapphire rpc url. * Delete stress test. * Fix init_dev_wallets. * Work on many random failures. * Use ad-hoc accounts for many_random. * Add Goerli RPC URL. * Fixes to encode_input. * Adds another encode_input fix. * Fix queries tests except for delegation failure. * Fix test allocation sampling, black, mypy. * Fix a pylint complaint. * Adapt waiting in test_queries. * Fix many_random test. * Replace with acc1. * Add some minting. * Revert "Replace with acc1." This reverts commit c6cad4b. * Temporarily skip test many random. * Remove prev minting. * Change multisig contract address being called. * Remove some todos. * Another removed todo. * Fix cyclic import issue. * Fix pylint complaints. * Update .gitignore * Remove build folder * Update gitignore * Add ocean-contracts as a dependency * Update contract_util to use artifacts * Fix undefined var * Better error message * Simpletoken -> OceanToken * Fix contract name * Correct fee distributor contract name * Update contracts version * Ditching VestingWalletV0 * Correct SideStaking -> Staking * Revert * Remove SideStaking * Contracts version update * Fix source * Update vesting wallet contract * Rename file * Function for compiling * Move vesting wallet and fix error msg * Fix beneficiary * Rename simple token * Fix key error * Add print * Rename contract * Add gnosis safe abi * Add alternative path * Ignore missing - artifacts * Black * Fix bug * Remove unused vars * Fix return type * Unskip predictoor models test, it doesn't seem to have the sporadical failures. --------- Co-authored-by: trizin <25263018+trizin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #716
Changes proposed in this PR: