Expand yield metrics reported, and make them easier to compare

[idiom-bytes]

Fixes #487

DoD:

• Keep APY front and center.
• Review metrics being reported
• Added roundAPR, roundYield, lastRoundAPR, lastRoundYield.
• Merge from main PR updates for RouindYield and prepare this PR

Additionally:

• Added In other PRs: roundVolume, lastRoundVolume
• ImproveD metrics reported so they are easier to compare...This is a first pass, there is more work to be done. The APY/DCV/Allocation tabs should help improve this further.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
df-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 28, 2023 at 3:28PM (UTC)

[KatunaNorbert]

The metrics are looking good, we should decide which one to show. Looks like roundYield is the most realistic metric which we can present and can be most helpful for the user.

[EnzoVezzaro]

when you toggle the columns, some values go from 0.00% to 0 and others from 0.00% to undefined. They should stay at 0.00%

datafarming.-.Ocean.Farm.-.3.March.2023.mp4

[EnzoVezzaro]

These metrics are fine, but we keep adding information to the user. We need to filter out what's most relevant for the user.

While doing some discovery I came across some products that are doing a great good displaying this information, for what I can see most platform play around with APR and APY this way:

Harvest:

Instadapp Lite:

Curve:

Pancake Swap:

Yield Finance:

DeFi Lama:

This might not be exactly our use case, but it can help us identifying what're the most important metrics to show. for what i see, simplicity is key for the user.

[jamiehewitt15]

I thought we had agreed in the meeting to get rid of the annualised numbers (APY and APR)? By taking the yield for the round and multiplying it by 52, we are not creating helpful information for the user - we are just extrapolating to present unreliable figures to them.

[idiom-bytes]

As discussed, we still want to lead with APY (it's the industry standard way of communicating the variable annual compound rate).

• Room to improve visualization around variable rate. I.E. tooltips, calling it vAPY (it's out there)
• We need to update docs.
• We need to improve UX (i.e. add accordion to provide more details)
• Room to improve via new calcs in df-sql: avg_apy_last_3_weeks
• Will sort out bugs wrt bad nums.
  - Will move to draft until it's further along.

Please see discussion on slack
https://oceanprotocol.slack.com/archives/C03L5JZRJ94/p1677986331788659?thread_ts=1677819414.500449&cid=C03L5JZRJ94

[jamiehewitt15]

• Room to improve visualization around variable rate. I.E. tooltips, calling it vAPY (it's out there)

Yeah, I'd still prefer for us to avoid APY altogether, but if we must show it then it makes sense to acknowledge the variability.

• Room to improve via new calcs in df-sql: avg_apy_last_3_weeks

I find this confusing. APY is an annualised rate, so why would a user want to see it averaged over a three-week period?

[KatunaNorbert]

I propose the following steps:

• Keep only one metric visible by default, that could be APY, and then as mentioned above improve it by name, tooltip message etc.
• Make rows expandable and add more metrics + explanation there. We can do it following this docs: https://carbon-components-svelte.onrender.com/components/DataTable#expandable-rows.

[EnzoVezzaro]

• Make rows expandable and add more metrics + explanation there. We can do it following this docs: https://carbon-components-svelte.onrender.com/components/DataTable#expandable-rows.

Yes, this is the intention. we are working on a quick mockup for it on miro.

[KatunaNorbert]

Added extendable row containing current and last round APYs

[jamiehewitt15]

The arrow on the left is so small I can imagine a lot of people wouldn't notice it. I suggest making it bigger, we could also make it so that clicking anywhere in the white space also expands the row.

[EnzoVezzaro]

Sorry for letting you know just know 😅 I just realised that your design might conflict a bit with what we're been preparing in miro. I'll post here the high level mockup we have on the board.

[KatunaNorbert]

@EnzoVezzaro Thanks for letting me know, although I don't think we want to get all those changes in this PR. Let's just add the APY/APR/Yield and keep updating the extended row in other PRs.

[EnzoVezzaro]

I don't see the expanded view anymore 😶

[KatunaNorbert]

That was removed on @idiom-bytes request

[EnzoVezzaro]

That was removed on @idiom-bytes request

I see 👍🏽

[EnzoVezzaro]

LGTM 👍🏽

[jamiehewitt15]

Looks good to me