Skip to content

Comments

Added arweave in the publishing with hosting services page#1165

Merged
LoznianuAnamaria merged 10 commits intomainfrom
feature/publish_with_arweave
Dec 21, 2022
Merged

Added arweave in the publishing with hosting services page#1165
LoznianuAnamaria merged 10 commits intomainfrom
feature/publish_with_arweave

Conversation

@LoznianuAnamaria
Copy link
Contributor

@LoznianuAnamaria LoznianuAnamaria commented Dec 20, 2022

No description provided.

@LoznianuAnamaria LoznianuAnamaria marked this pull request as ready for review December 20, 2022 13:31
@mariacarmina
Copy link
Contributor

Should we hide some IDs from the screenshots?

@LoznianuAnamaria
Copy link
Contributor Author

Should we hide some IDs from the screenshots?

I don't think they are leaking anything so I wouldn't bother

Copy link
Contributor

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamiehewitt15
Copy link
Contributor

jamiehewitt15 commented Dec 20, 2022

We should also update the initial part of this page:

  1. The page description should mention Arweave given that it's one of the examples.
  2. The first paragraph should mention that users can use either centralised storage or decentralised storage. At the moment it reads as if an HTTP URL is the only option.
  3. The first screenshot should be updated as it's currently out of date.

Also, some formatting changes:

  1. Overview should be an H2 title
  2. Rather than having Hosting Services as an H3 title, I would have two separate H2 titles: Decentralised Hosting and Centralised Hosting
  3. Arweave, AWS and Azure should be H3 titles instead of H4 titles.

The ideal behind these formatting changes is to get a the side menu to work better and nicely show the different sections of this page, which should help with navigation.

@LoznianuAnamaria
Copy link
Contributor Author

Great suggestions @jamiehewitt15 👍 I've integrated them all and updated the PR.
Please let me know if you see something off or if you have other things you think should be changed.
Thanks 🙏

Co-authored-by: Jamie Hewitt <jamie@oceanprotocol.com>
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit da00116 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@LoznianuAnamaria LoznianuAnamaria merged commit 4c70542 into main Dec 21, 2022
@LoznianuAnamaria LoznianuAnamaria deleted the feature/publish_with_arweave branch December 21, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants