Skip to content

Conversation

@kremalicious
Copy link
Contributor

@kremalicious kremalicious commented Mar 1, 2021

closes #415

Changes proposed in this PR:

  • differentiate between no price set (no price.address), and low liquidity (no price.isConsumable)
  • centralize all checks in Price component

Screen Shot 2021-03-01 at 16 11 29

Screen Shot 2021-03-01 at 16 11 49

Screen Shot 2021-03-01 at 16 14 54

Screen Shot 2021-03-01 at 16 15 21

@vercel
Copy link

vercel bot commented Mar 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oceanprotocol/market/9A2nP6aP5VZumeRwptYU6a7Gnyxr
✅ Preview: https://market-git-fix-price-display-oceanprotocol.vercel.app

@kremalicious kremalicious mentioned this pull request Mar 1, 2021
@kremalicious kremalicious marked this pull request as ready for review March 1, 2021 15:18
@kremalicious kremalicious requested a review from mihaisc as a code owner March 1, 2021 15:18
@kremalicious kremalicious merged commit 68f0d37 into main Mar 1, 2021
@kremalicious kremalicious deleted the fix/price-display branch March 1, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect "No price found" message

3 participants