Skip to content

Comments

Removing showing updates on never updated assets#438

Merged
kremalicious merged 2 commits intomainfrom
fix/436
Mar 16, 2021
Merged

Removing showing updates on never updated assets#438
kremalicious merged 2 commits intomainfrom
fix/436

Conversation

@DimitarSD
Copy link

@DimitarSD DimitarSD commented Mar 15, 2021

Fixes #436
Closes oceanprotocol/ocean-subgraph#54

Changes proposed in this PR:

  • Removes datatokens.createTime & datatokens.tx from the ReceiptData query
  • Removes showing updates on never updates assets (using only datatokens.updates)

@vercel
Copy link

vercel bot commented Mar 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oceanprotocol/market/DafGDPpqFvFtWt4wdxNZ3wWJP7UT
✅ Preview: https://market-git-fix-436-oceanprotocol.vercel.app

@kremalicious
Copy link
Contributor

yeah, that package-lock: long story short, with npm v7 (which is default with Node.js v15) the lock file will automatically be updated to lockfileVersion v2 upon doing npm install. But npm v7 comes with some more challenges for us so we were holding off on too many dependency updates.

For now, what would work for this PR, is to get the old Node.js v14/npm v6 lock file, if you use nvm:

nvm use 14
npm i
git commit
git push

This should restore the v1 lock file version. Also we kinda forgot to document the need for npm below v7, since it only arises as problem when adding/changing dependencies.

Other than that, the actual fix works perfectly on first quick look 🥳

@mihaisc
Copy link
Contributor

mihaisc commented Mar 16, 2021

All good

@kremalicious kremalicious marked this pull request as ready for review March 16, 2021 18:22
@kremalicious kremalicious merged commit c9a8345 into main Mar 16, 2021
@kremalicious kremalicious deleted the fix/436 branch March 16, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit history shows updates on never updated assets

3 participants