Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oceanprotocol/market/FeenipgDNq7KLgQmXwcQu8gjv5Fc |
|
The issue we still add in query |
|
@claudiaHash Thank you for pointing that out, I have fixed the filters now. @mihaisc I used
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-term-query.html |
kremalicious
left a comment
There was a problem hiding this comment.
perfect functionality-wise. Crazy how bad our search was before :-)
|
right, the merge conflict. @jamiehewitt15 could you take another look at this please? As we now need to combine your changes with the query for multiple chainIds we now have in |
|
Ah yes, @jamiehewitt15 while merging could also change the chain id query to use match/tern in the boolean query (like we do with type and isPurgatory), and not leave it as a query string. 😁 |
kremalicious
left a comment
There was a problem hiding this comment.
as mentioned, merge main and adapt query. Then we should all test it again
|
Code Climate has analyzed commit 8a096a5 and detected 0 issues on this pull request. View more on Code Climate. |
kremalicious
left a comment
There was a problem hiding this comment.
works flawlessly for me, now also with combinations of different networks selected and such, amazing improvement overall!


Closes: #678
Changes proposed in this PR: