Skip to content

Parse JSON config file.#1034

Merged
mariacarmina merged 44 commits intomainfrom
feature/config-file
Sep 30, 2025
Merged

Parse JSON config file.#1034
mariacarmina merged 44 commits intomainfrom
feature/config-file

Conversation

@mariacarmina
Copy link
Contributor

@mariacarmina mariacarmina commented Sep 1, 2025

Fixes #1020 .

Changes proposed in this PR:

  • implement function for loading json file as config if CONFIG_PATH variable is specified
  • unit tests for getConfiguration() function
  • added new .env test file for config updated docs.

@mariacarmina mariacarmina self-assigned this Sep 1, 2025
@mariacarmina mariacarmina marked this pull request as ready for review September 8, 2025 10:00
@giurgiur99
Copy link
Contributor

Please link the issue

@giurgiur99
Copy link
Contributor

Should we also backward support the .env config?

Copy link
Contributor

@giurgiur99 giurgiur99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a config.example.json, similar to .env.example

Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20
Copy link
Member

@giurgiur99 pls review

Copy link
Contributor

@giurgiur99 giurgiur99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariacarmina mariacarmina merged commit 95d179c into main Sep 30, 2025
13 checks passed
@mariacarmina mariacarmina deleted the feature/config-file branch September 30, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node JSON config file

3 participants