Skip to content

Bug/fix claim with withdraw#1087

Merged
alexcos20 merged 2 commits intomainfrom
bug/fix_claim_with_withdraw
Oct 31, 2025
Merged

Bug/fix claim with withdraw#1087
alexcos20 merged 2 commits intomainfrom
bug/fix_claim_with_withdraw

Conversation

@alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Oct 30, 2025 •
edited
Loading

Changes proposed in this PR:

  • increase claim timeout to 3600 sec from 600
  • call claimLockAndWithdraw instead of just claimLock

Why?

  • claimLock claims a lock, but keeps funds in escrow contract, as available
  • claimLockAndWithdraw claims a lock, but also withdraws the amount to node address

To Do someday

  • use claimLock (it's cheaper) and have crons to withdraw available amounts

@alexcos20 alexcos20 self-assigned this Oct 30, 2025
@alexcos20 alexcos20 merged commit 957a104 into main Oct 31, 2025
29 of 31 checks passed
@alexcos20 alexcos20 deleted the bug/fix_claim_with_withdraw branch October 31, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndrpp ndrpp ndrpp approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@giurgiur99 giurgiur99 Awaiting requested review from giurgiur99 giurgiur99 is a code owner

@denisiuriet denisiuriet Awaiting requested review from denisiuriet denisiuriet is a code owner

@andreip136 andreip136 Awaiting requested review from andreip136 andreip136 is a code owner

Assignees

@alexcos20 alexcos20

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcos20 @ndrpp