Skip to content

chore: fix algo validation#1092

Merged
AdriGeorge merged 1 commit intomainfrom
feat/fix-algo-validation
Nov 4, 2025
Merged

chore: fix algo validation#1092
AdriGeorge merged 1 commit intomainfrom
feat/fix-algo-validation

Conversation

@AdriGeorge
Copy link
Collaborator

Changes proposed in this PR:

Updated the  validateAlgoForDataset  logic to correctly handle the following cases:
• The algorithm should pass validation if it matches either  publisherTrustedAlgorithms  or publisherTrustedAlgorithmPublishers .
• It should not be required to appear in both lists simultaneously.

Example:

        "compute": {
          "publisherTrustedAlgorithms": [
            {
              "filesChecksum": "2c36c054711dad021f45cc7e0990bd38864a51d753c8055b63e78014a6bee515",
              "containerSectionChecksum": "ad2e6cf7e1997f2c95098b8a968251d645b29ba1047ceab23d4765cda5b4754a",
              "serviceId": "9ce2ebf988ae1ded0c409248fca32ff7c8288fca560af818bb2fbefd990d94e8",
              "did": "did:ope:bf25f53071fd49d9b3e733032f25943539d92f97ff787a031461625987f5ad0c"
            }
          ],
          "publisherTrustedAlgorithmPublishers": [
            "*"
          ],
          "allowRawAlgorithm": false,
          "allowNetworkAccess": true
        }

In this configuration, all algorithms should pass validation because the wildcard  "*"  in publisherTrustedAlgorithmPublishers  allows any publisher. Previously, only the algorithms listed under publisherTrustedAlgorithms  would pass.

@AdriGeorge AdriGeorge merged commit ee20908 into main Nov 4, 2025
29 of 31 checks passed
@AdriGeorge AdriGeorge deleted the feat/fix-algo-validation branch November 4, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants