Skip to content

Update publisherTrustedAlgorithmPublishers and publisherTrustedAlgorithms#950

Merged
mariacarmina merged 34 commits intomainfrom
feature/update-trusted-algos-credentials
Jun 13, 2025
Merged

Update publisherTrustedAlgorithmPublishers and publisherTrustedAlgorithms#950
mariacarmina merged 34 commits intomainfrom
feature/update-trusted-algos-credentials

Conversation

@mariacarmina
Copy link
Copy Markdown
Contributor

@mariacarmina mariacarmina commented Jun 2, 2025

Fixes #943 #945 .

Changes proposed in this PR:

  • Update publisherTrustedAlgorithmPublishers logic for allowing/denying all addresses
  • Update publisherTrustedAlgorithm logic for allowing/denying all algorithm DIDs
  • Added tests
  • Docs updated here

…thm logic for allowing all datasets DIDs or algorithm DIDs.
@mariacarmina mariacarmina self-assigned this Jun 2, 2025
@mariacarmina mariacarmina changed the title Update publisherTrustedAlgorithmPublishers and publisherTrustedAlgorithm logic for allowing all datasets DIDs or algorithm DIDs Update publisherTrustedAlgorithmPublishers and publisherTrustedAlgorithms Jun 5, 2025
@mariacarmina mariacarmina marked this pull request as ready for review June 5, 2025 12:59
@mariacarmina mariacarmina marked this pull request as draft June 6, 2025 04:18
@mariacarmina mariacarmina marked this pull request as ready for review June 6, 2025 13:13
@bogdanfazakas
Copy link
Copy Markdown
Member

think this is missing this logic

  • Add the serviceId field to the object within the publisherTrustedAlgorithms array. to enable searching on both asset id and service id. The structure of the object within publisherTrustedAlgorithms will look as follows:

{
"did": "".
"serviceId": "",
"filesChecksum": "",
"containerSectionChecksum": ""
}

part of #945

@mariacarmina
Copy link
Copy Markdown
Contributor Author

think this is missing this logic

  • Add the serviceId field to the object within the publisherTrustedAlgorithms array. to enable searching on both asset id and service id. The structure of the object within publisherTrustedAlgorithms will look as follows:

{ "did": "". "serviceId": "", "filesChecksum": "", "containerSectionChecksum": "" }

part of #945

I will comment on the issue regarding the need of serviceId parameter, for now it was not established in the meetings to include serviceId in trusted algo shape. Right now the algorithm can be searched by unique DID, it is a bit unclear described the need to search/filter the access of trusted algorithms by service. Filtering by service can be meaningful when you handle with multiple fixed rates attached to the algorithm, but not sure if it helps for allowing the algorithm to run on a specific dataset (access control).

Thank you!

Copy link
Copy Markdown
Contributor

@giurgiur99 giurgiur99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariacarmina mariacarmina merged commit 4544b33 into main Jun 13, 2025
13 checks passed
@mariacarmina mariacarmina deleted the feature/update-trusted-algos-credentials branch June 13, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update behavior for publisherTrustedAlgorithmPublishers field processing

3 participants