Conversation
| except ImportError: | ||
| from md5 import md5 | ||
|
|
||
| __name__ = 'pyitunes' |
There was a problem hiding this comment.
I'm certainly not trying to scrub attribution out of the source file; it just seems like Python libraries these days tend to convey this information solely via pyproject.toml, rather than these dunder attributes. If you'd prefer to keep them, I can look at using dynamic fields in pyproject.toml so that they only need to be specified in one place.
I've specified the “GPL-3.0-or-later” license on the basis that, at the time it was committed, the license URL in `setup.py` linked to [the text of GPL 3.0], and in my experience, “or later” is the typical expectation of forward GPL version compatibility when left unspecified. [the text of GPL 3.0]: https://web.archive.org/web/20110629093753/http://www.gnu.org/copyleft/gpl.html
Co-authored-by: Jag_k <30597878+jag-k@users.noreply.github.com>
Co-authored-by: tal <talolard@gmail.com>
Co-authored-by: tal <talolard@gmail.com>
As of iOS 17.2, movies and TV shows are not listed in the iTunes Store at all. Although the API will still accept queries for the “movie” media type, it does not seem to return any results.
18e3ae6 to
e82c73f
Compare
|
|
||
| [project] | ||
| name = "python-itunes" | ||
| version = "1.0" |
There was a problem hiding this comment.
I wasn't sure what to put here: 0.2 (from __init__.py), 1.0 (from setup.py/PyPI), or 1.0.0 (i.e., take the opportunity to switch to a SemVer/Pride Versioning-style triple-barrel version number). In the end, I decided it was probably best to keep editorial changes out of this PR as much as possible, and so I kept 1.0.
|
Thank you for merging so quickly! This library has been very useful to me for eight or nine years now as part of my music library management (I use it for automated retrieval of high-resolution album art), and I hope Apple don't turn the lights off on the API any time soon. |
This PR updates the library for compatibility with Python 3.
setup.pylibrary definition with apyproject.tomlfile. This does change the development workflow a bit (requires an editable installation into a venv), but shouldn't have any ramifications for downstream consumers of the library.If merged, this would supersede #17 and #30.
Please note also the message of the first commit in the series:
If you can provide confirmation or clarification of your intent, @ocelma, I'll happily reword the message to be less speculative.