feat: migrate from globby to tinyglobby #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @spanishpear to sign the Salesforce Inc. Contributor License Agreement. |
spanishpear
changed the title
This was referenced Apr 26, 2025
spanishpear
changed the title
Contributor
Author
|
👋 @cristiand391 apologies for the ping - would you be okay to take a look at this? ❤️ Thanks! |
Contributor
|
@spanishpear Thanks - this is a great contribution 🏆 I'm going to merge this into a separate branch so that the integration tests can run. Once those pass, I'll merge this into main |
mdonnalley
added a commit
that referenced
this pull request
Jun 2, 2025
Contributor
Author
|
Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
What is this PR
This PR migrates
globbyto tinyglobby, and reducing the total oclif/core dependencies by ~21 (see graphs below)Tinyglobby has ~52M downloads a month, used by many other large consumers (vite, pnpm, etc) - it has only 2 subdependencies, compared to globby's 23 and fast-glob's 17.
This will reduce the total #deps down by 21 🥳 It's also in-line with the e18e ecosystem cleanup initative
Context
I was looking at oclif's dependency graph https://npmgraph.js.org/?q=%40oclif%2Fcore#select=exact%3Aglobby%4011.1.0 and noticed that globby was being pulled in with it's 23 dependencies, for just one line of usage!
Compared to after this PR
Aside
I've read https://github.com/oclif/core/blob/main/CONRTIBUTING.md#dependencies and its note around Dependencies - but as this was not a dependency bump, i have raised this :)
Thank you for your time!