This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Checks earlier if macos.identifier is set #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @Junkern to sign the Salesforce.com Contributor License Agreement. |
Contributor
|
I think this is possible but you'll need to move the code around a bit more as that variable isn't defined at this point. See the test failure |
Contributor
Author
|
You are right, I was too quick in making the PR :D Fixed the PR and also signed the CLA @jdxcode |
jdx
approved these changes
May 16, 2018
oclif-bot
added a commit
that referenced
this pull request
May 16, 2018
<a name="1.13.22"></a> ## [1.13.22](v1.13.21...v1.13.22) (2018-05-16) ### Bug Fixes * check earlier if macos.identifier is set ([#35](#35)) ([2e0e4eb](2e0e4eb))
Contributor
|
🎉 This PR is included in version 1.13.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to check this in the beginning of the script and not after the tarball has been build. Will save time for new users.