Support JIT plugin version wildcards#1287
Open
bailey-coding wants to merge 1 commit intooclif:mainfrom
Open
Conversation
|
Thanks for the contribution! Before we can merge this, we need @bailey-coding to sign the Salesforce Inc. Contributor License Agreement. |
Author
|
I signed it |
|
@bailey-coding , I'll get this reviewed shortly, and we'll make sure you're credited. |
Author
I don't mind too much about credit, but getting it reviewed, and if it makes sense approved and merged would be amazing. Thank you! 🙏 |
|
@bailey-coding , the PR looks solid, and I'm satisfied with my manual QA. Ideally, you could also add test coverage for the new fix, with something that used to fail and now passes thanks to the fix. Is that something you'd be able to do at this time? |
Author
|
Yeah, for sure. I can add some tests tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1286