Skip to content

fix: throw error if missing cmd arg #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshanemc merged 2 commits into from
Jan 17, 2023
Merged

fix: throw error if missing cmd arg #317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a5fd96
fix: throw error if missing cmd arg
cristiand391 Jan 9, 2023
2ad0367
Update src/commands/which.ts
cristiand391 Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/commands/which.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ import {Command, CliUx} from '@oclif/core'
export default class Which extends Command {
static description = 'Show which plugin a command is in.'
static strict = false;
static examples = [
{
description: 'See which plugin the `help` command is in:',
command: '<%= config.bin %> <%= command.id %> help',
},
]

async run(): Promise<void> {
const {argv} = await this.parse(Which)
Copy link
Copy Markdown
Member Author

@cristiand391 cristiand391 Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this used to be an oclif arg, but we parse argv to support space-separated commands without quotes, see:
#194

Expand All @@ -12,6 +18,8 @@ export default class Which extends Command {
// If this if statement is true then the command to find was passed in as a single string, e.g. `mycli which "my command"`
// So we must use the topicSeparator to split it into an array
command = argv[0].split(this.config.topicSeparator)
} else {
throw new Error('"which" expects a command name. Try something like "which your:command:here" ')
}

const cmd = this.config.findCommand(command.join(':'), {must: true})
Expand Down