Skip to content

Unify Scratch angle and internal angle handling for actor rotation#302

Merged
oco777 merged 1 commit intomainfrom
codex/unify-scratch-and-internal-angle-handling
Nov 15, 2025
Merged

Unify Scratch angle and internal angle handling for actor rotation#302
oco777 merged 1 commit intomainfrom
codex/unify-scratch-and-internal-angle-handling

Conversation

@oco777
Copy link
Copy Markdown
Owner

@oco777 oco777 commented Nov 15, 2025

Summary

  • add a ScratchAngleUtil runtime helper to convert between Scratch角度 and 内部角度
  • convert ScratchUnits that manipulate actor direction so ActorPresenter receives 内部角度 values
  • clarify direction terminology in ActorPresenterAdapter and VS_Scratch_Mapping.md

Testing

  • not run (not requested)

Codex Task

@oco777 oco777 merged commit 7d7a17c into main Nov 15, 2025
3 checks passed
@oco777 oco777 deleted the codex/unify-scratch-and-internal-angle-handling branch November 15, 2025 08:29
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

// Updated: 2025-10-23
using UnityEngine;
namespace FUnity.Runtime.Core
{

P1 Badge Check in ScratchAngleUtil.cs.meta

Root AGENTS.md mandates that every new .cs file is committed together with its Unity–generated .meta, yet the newly added Runtime/Core/ScratchAngleUtil.cs has no accompanying .meta file in this change set. Unity will create ScratchAngleUtil.cs.meta automatically with a new GUID the next time the project is opened, so anyone syncing this commit will immediately get a dirty worktree and risk GUID mismatches for references to this script. Please add the generated .meta file so the repository stays consistent.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant