Skip to content

fix: disambiguate Scratch thread context overloads#312

Merged
oco777 merged 1 commit intomainfrom
codex/fix-cs0121-ambiguity-in-trygetthreadcontext
Nov 16, 2025
Merged

fix: disambiguate Scratch thread context overloads#312
oco777 merged 1 commit intomainfrom
codex/fix-cs0121-ambiguity-in-trygetthreadcontext

Conversation

@oco777
Copy link
Copy Markdown
Owner

@oco777 oco777 commented Nov 16, 2025

Summary

  • ensure Scratch thread context lookups specify string-based out parameters where needed
  • enforce Guid-based thread retrieval in stop control units to avoid overload ambiguity
  • document the Guid-based context usage for Scratch stop units

Testing

  • dotnet build (fails: dotnet CLI not available in container)

Codex Task

@oco777 oco777 merged commit fc4e8d1 into main Nov 16, 2025
3 checks passed
@oco777 oco777 deleted the codex/fix-cs0121-ambiguity-in-trygetthreadcontext branch November 16, 2025 04:20
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if (ScratchUnitUtil.TryGetThreadContext(flow, out _, out Guid threadId))
{
FUnityScriptThreadManager.Instance.StopThread(threadId);

P1 Badge Import System for Guid usage in stop units

Both stop units now declare Guid threadId, but this file does not import System, so Guid is undefined and the file will not compile. Any build that touches these units will fail until System.Guid is referenced (e.g., via using System; or full qualification).

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant