Conversation
There was a problem hiding this comment.
💡 Codex Review
RunEventCoroutine now returns immediately when ShouldTrigger is false, but the Flow allocated in TriggerWithThreadRegistration is no longer wrapped in a using or passed to Flow.StartCoroutine. Because this unit listens to EventHooks.Update, the monitored key will be unpressed most frames, so every frame allocates a Flow that is never disposed, steadily leaking memory/GC pressure during normal play. The prior using (flow) cleaned up these skipped events; some disposal is still needed for the non-trigger path.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Testing
Codex Task