Skip to content

Commit 57865b3

Browse files
devversionthePunderWoman
authored andcommitted
ci: do not update shared dev-infra package in components-repo-unit-tests job (angular#42268)
The shared dev-infra package from `HEAD` should not be installed when running the `components-repo-unit-tests` job. This is done because otherwise changes to the dev-infra package can result in build setup issues for the CI job (while the goal of the CI job is to test the framework) PR Close angular#42268
1 parent a16f82b commit 57865b3

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,8 +737,8 @@ jobs:
737737
- run:
738738
# Updates the `angular/components` `package.json` file to refer to the release output
739739
# inside the `packages-dist` directory.
740-
name: Setting up release packages.
741-
command: node scripts/ci/update-deps-to-dist-packages.js ${COMPONENTS_REPO_TMP_DIR}/package.json dist/packages-dist/
740+
name: Setting up framework release packages.
741+
command: node scripts/ci/update-framework-deps-to-dist-packages.js ${COMPONENTS_REPO_TMP_DIR}/package.json dist/packages-dist/
742742
- run:
743743
# Run `yarn install` again to install the Angular packages from `packages-dist/` and update the lockfile.
744744
# NOTE: We cannot rely on Bazel to run `yarn install`, because it uses the `--frozen-lockfile` flag and fails.

docs/DEBUG_COMPONENTS_REPO_IVY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ the `angular/angular` repo.
1313
command in the `angular/angular` repo:
1414

1515
```bash
16-
node ./scripts/ci/update-deps-to-dist-packages.js {COMPONENTS_REPO}/package.json ./dist/packages-dist
16+
node ./scripts/ci/update-framework-deps-to-dist-packages.js {COMPONENTS_REPO}/package.json ./dist/packages-dist
1717
```
1818

1919
4\) Switch into the `angular/components` repository and run the tests by using the

scripts/ci/update-deps-to-dist-packages.js renamed to scripts/ci/update-framework-deps-to-dist-packages.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ const updated = [];
2929
const skipped = [];
3030
function updateDeps(dependencies) {
3131
for (const packageName of Object.keys(dependencies)) {
32-
// We're only interested to update packages in the @angular scope
33-
if (!packageName.startsWith('@angular/')) {
32+
// We're only interested to update packages in the `@angular` scope. The shared dev-infra
33+
// package is not updated as it's not a package that is part of the Angular framework.
34+
if (!packageName.startsWith('@angular/') || packageName === '@angular/dev-infra-private') {
3435
continue;
3536
}
3637

0 commit comments

Comments
 (0)