Fix emitting broken toplevel bytecode #1130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Introduced in #1121. |
Member
|
I've extended your fix a bit in #1131 |
AltGr
added a commit
to AltGr/learn-ocaml
that referenced
this pull request
Sep 17, 2021
It has a breaking bug, see ocsigen/js_of_ocaml#1130
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Oct 7, 2021
…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-ocamlbuild, js_of_ocaml-lwt and js_of_ocaml-compiler (3.11.0) CHANGES: ## Features/Changes * Compiler: setting tc_depth to 0 remove direct call from the tc optimization. * Lib: add hidden, onfullscreenchange and onwebkitfullscreenchange to document * Runtime: fixes for Windows, all tests pass * Runtime: make all windows drive available on nodejs. * Runtime: add support for Sys.mkdir and Sys.rmdir * Runtime: make stdin work on nodejs * Runtime: add support for Unix(stat,lstat,mkdir,rmdir,symlink,readlink,unlink,getuid) on nodejs. * Runtime: add caml_raise_with_args ## Bug fixes * Compiler: fix toplevel generation (ocsigen/js_of_ocaml#1129, ocsigen/js_of_ocaml#1130, ocsigen/js_of_ocaml#1131) * Compiler: fix predefined exn id with separate compilation * Compiler: js stubs without 'Provides' should still allow 'Require' * Runtime: fix handling of uncaugh exceptions * Runtime: fix error handling of Sys.readdir * Dune: make git version lookup more resilient
hhugo
added a commit
to hhugo/opam-repository-mingw
that referenced
this pull request
Oct 7, 2021
…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-ocamlbuild, js_of_ocaml-lwt and js_of_ocaml-compiler (3.11.0) CHANGES: ## Features/Changes * Compiler: setting tc_depth to 0 remove direct call from the tc optimization. * Lib: add hidden, onfullscreenchange and onwebkitfullscreenchange to document * Runtime: fixes for Windows, all tests pass * Runtime: make all windows drive available on nodejs. * Runtime: add support for Sys.mkdir and Sys.rmdir * Runtime: make stdin work on nodejs * Runtime: add support for Unix(stat,lstat,mkdir,rmdir,symlink,readlink,unlink,getuid) on nodejs. * Runtime: add caml_raise_with_args ## Bug fixes * Compiler: fix toplevel generation (ocsigen/js_of_ocaml#1129, ocsigen/js_of_ocaml#1130, ocsigen/js_of_ocaml#1131) * Compiler: fix predefined exn id with separate compilation * Compiler: js stubs without 'Provides' should still allow 'Require' * Runtime: fix handling of uncaugh exceptions * Runtime: fix error handling of Sys.readdir * Dune: make git version lookup more resilient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.