Skip to content

Conversation

@hhugo
Copy link
Member

@hhugo hhugo commented Sep 17, 2021

extend #1130
fix #1129

  • String.split_char had a surprising/wrong behavior of not round-tripping with String.concat. We can use the upstream one now that the minimal ocaml version is 4.04
  • Add (minimal) testing for the toplevel

@AltGr
Copy link

AltGr commented Sep 17, 2021

I often say that there are as many string_split variants as projects :)

Thanks!

@hhugo hhugo merged commit 6389516 into master Sep 17, 2021
@hhugo hhugo deleted the fix-toplevel branch September 17, 2021 08:52
@hhugo hhugo restored the fix-toplevel branch September 17, 2021 20:22
@hhugo hhugo deleted the fix-toplevel branch September 21, 2021 08:39
mseri pushed a commit to ocaml/opam-repository that referenced this pull request Oct 7, 2021
…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-ocamlbuild, js_of_ocaml-lwt and js_of_ocaml-compiler (3.11.0)

CHANGES:

## Features/Changes
* Compiler: setting tc_depth to 0 remove direct call from the tc optimization.
* Lib: add hidden, onfullscreenchange and onwebkitfullscreenchange to document
* Runtime: fixes for Windows, all tests pass
* Runtime: make all windows drive available on nodejs.
* Runtime: add support for Sys.mkdir and Sys.rmdir
* Runtime: make stdin work on nodejs
* Runtime: add support for Unix(stat,lstat,mkdir,rmdir,symlink,readlink,unlink,getuid) on nodejs.
* Runtime: add caml_raise_with_args

## Bug fixes
* Compiler: fix toplevel generation (ocsigen/js_of_ocaml#1129, ocsigen/js_of_ocaml#1130, ocsigen/js_of_ocaml#1131)
* Compiler: fix predefined exn id with separate compilation
* Compiler: js stubs without 'Provides' should still allow 'Require'
* Runtime: fix handling of uncaugh exceptions
* Runtime: fix error handling of Sys.readdir
* Dune: make git version lookup more resilient
hhugo added a commit to hhugo/opam-repository-mingw that referenced this pull request Oct 7, 2021
…s_of_ocaml-ppx_deriving_json, js_of_ocaml-ppx, js_of_ocaml-ocamlbuild, js_of_ocaml-lwt and js_of_ocaml-compiler (3.11.0)

CHANGES:

## Features/Changes
* Compiler: setting tc_depth to 0 remove direct call from the tc optimization.
* Lib: add hidden, onfullscreenchange and onwebkitfullscreenchange to document
* Runtime: fixes for Windows, all tests pass
* Runtime: make all windows drive available on nodejs.
* Runtime: add support for Sys.mkdir and Sys.rmdir
* Runtime: make stdin work on nodejs
* Runtime: add support for Unix(stat,lstat,mkdir,rmdir,symlink,readlink,unlink,getuid) on nodejs.
* Runtime: add caml_raise_with_args

## Bug fixes
* Compiler: fix toplevel generation (ocsigen/js_of_ocaml#1129, ocsigen/js_of_ocaml#1130, ocsigen/js_of_ocaml#1131)
* Compiler: fix predefined exn id with separate compilation
* Compiler: js stubs without 'Provides' should still allow 'Require'
* Runtime: fix handling of uncaugh exceptions
* Runtime: fix error handling of Sys.readdir
* Dune: make git version lookup more resilient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Error with lwt_example

3 participants