runtime(js): fix useTemplate #1862
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sora Morimoto <sora@morimoto.io>
There was a problem hiding this comment.
PR Overview
This PR updates various JavaScript runtime files to use template literals for string concatenation, thereby improving code readability and consistency.
- Updated string concatenation in file path calculations of fs_fake.js
- Replaced concatenated error messages and string operations with template literals in multiple runtime files
- Standardized formatting across modules including sys.js, fs.js, str.js, wasm/runtime.js, graphics.js, ieee_754.js, parsing.js, unix.js, ints.js, io.js, jslib.js, and marshal.js
Reviewed Changes
| File | Description |
|---|---|
| runtime/js/fs_fake.js | Converted concatenation syntax in path and regex generation to template literals |
| runtime/js/sys.js | Updated error message and value formatting to template literals |
| runtime/js/fs.js | Standardized string concatenation for error messages and function returns |
| runtime/js/str.js | Reformatted escape sequence concatenation to use template literal |
| runtime/wasm/runtime.js | Changed string construction to template literals for clarity |
| runtime/js/graphics.js | Converted string concatenations for canvas operations into template literals |
| runtime/js/ieee_754.js | Updated float formatting functions to use template literals |
| runtime/js/parsing.js | Refactored log message concatenations to template literals |
| runtime/js/unix.js | Updated system error message construction to template literals |
| runtime/js/ints.js | Simplified integer conversion using String() |
| runtime/js/io.js | Converted error message concatenations to template literals |
| runtime/js/jslib.js | Updated log message formatting with template literals |
| runtime/js/marshal.js | Replaced string concatenation with template literals in error handling |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
hhugo
reviewed
Mar 17, 2025
Member
hhugo
left a comment
hhugo
left a comment
There was a problem hiding this comment.
I don't like complex expressions inside templates. They makes review harder in my experience.
I think I would prefer if templates only embed simple identifiers.
Member
|
@smorimoto, do you plan to do anything with this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template is another one that is already widely used and documented.