ppx: upgrade to ppxlib 0.36 #1866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorimoto
reviewed
Mar 11, 2025
smorimoto
added
no changelog
dependencies
hhugo
force-pushed
the
anmonteiro/ppxlib-0.36-ast-5.2
branch
from
99efd3f to
ea844f1
Compare
hhugo
reviewed
Mar 18, 2025
Member
hhugo
left a comment
hhugo
left a comment
There was a problem hiding this comment.
Blocked until the CI goes green
hhugo
reviewed
Mar 18, 2025
hhugo
reviewed
Mar 18, 2025
hhugo
reviewed
Mar 18, 2025
| | { pparam_desc = Pparam_val (label, _, _arg); _ } -> | ||
| Some (Arg.make ~label ())) | ||
| in | ||
| params @ create_meth_ty body |
Member
There was a problem hiding this comment.
I'm not sure we need to recurse here.
Author
There was a problem hiding this comment.
@hhugo the reason why I added recursion was for cases like this:
class x =
object
method foo a = fun b -> a + b
enddue to ocaml/ocaml#12236 preserving both Pexp_function nodes in the AST. I'm not very familiar with how JSOO handles this case, so I trust you to know whether it's unnecessary.
hhugo
reviewed
Mar 18, 2025
| | Pexp_function (params, _, Pfunction_body body) -> | ||
| let params = | ||
| List.filter_map params ~f:(function | ||
| | { pparam_desc = Pparam_newtype _; _ } -> None |
Member
There was a problem hiding this comment.
I'm not sure that this is what we want. I'll have to look futher
hhugo
force-pushed
the
anmonteiro/ppxlib-0.36-ast-5.2
branch
2 times, most recently
from
6fb1a5d to
3f4d8a2
Compare
hhugo
force-pushed
the
anmonteiro/ppxlib-0.36-ast-5.2
branch
from
3f4d8a2 to
afbfc00
Compare
Member
|
jsoo can now build with ppxlib.0.36. Running tests still requires ppxlib < 0.36 |
Member
|
Tests now run with ppxlib.0.36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppx_expectand its transitive deps need to be upgraded first before this change can be considered, but I'm opening this up to unblock some of my PRs in other repos (this builds fine if you don't run the tests)