-
Notifications
You must be signed in to change notification settings - Fork 198
Switch to OASIS #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to OASIS #60
Conversation
|
any comment ? |
|
Note that the opam file inside the js_of_ocaml repository is taken before the one I use for testing this. So I got a strange bug that I just figured out what it was :( |
|
This does not compile with OCaml 4.00.1 because menhir is called with the |
|
Anyway, eliom doesn't compiles with those changes |
|
@hhugo As far as I can understand by reading your patch in opam, the opam file inside the project repository is only used to build and remove (?). So we can just remove the things that are unused in both project repository and opam repository. (Dependencies, descr, install file, … for the project and build/remove for the opam repository) |
|
ocaml 4.00.1 |
|
@jpdeplaix I'm expecting the opam directory in js_of_ocaml to keep track of changes (Dependencies, descr, install file ..) so it can be used when pushing the next version to opam-repo. I don't think this opam file will ever get used by opam unless the project is "opam pin" |
|
I rewrote the hack in js_parser, it now works with ocaml 3.12, 4.00.1 |
|
While trying to compile cumulus with it, I got an error: |
|
I was able to build cumulus without error after I regenerated oasis file (see "fix previous") |
|
It still doesn't work with me :/ Did you tried with the new main repo ? (https://github.com/Cumulus/Cumulus) |
|
no, with master found in bitbucket, which is Cumulus/Cumulus@d862fca |
|
Then can you try with master (github) ? And if it works for you it's probably because I've the latest OASIS version :/ I'll try myself later. |
|
can you check the output of here is mine |
|
I have only the |
|
have you tried to regenerate it ? |
|
yes, it seems to fix the problem (see commit). Cumulus compiles fine now. Thanks |
|
Same for ocsimore. It's ok for me ! I give my vote for integrating this. |
|
funny, I had it working fine without these change. Just because osx is the case-insensitive by default (to be precise, HFS+ is configure to be case-insensitive by default) |
|
What is the status of this change? Shall we include it in the forthcoming Js_of_ocaml release? |
|
No need to include this in the forthcoming release. |
|
I'm glad you use the compiled_setup_ml but the |
|
And the |
|
Oh and the opam file isn't right :/ |
|
@jpdeplaix, you're welcome to push any commit to this PR |
|
This is not ready to merge. |
|
Ok, I'll do it later. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those 2 lines looks very bad. @jpdeplaix , any suggestion to make this clean ?
|
@jpdeplaix still working on Windows support for OASIS, no release of OASIS this week. Maybe in 2 weeks if I succeed managing Windows crazy setup. |
OASIS part1 merge update OPAM updates from jpd
|
@jpdeplaix, I've push & squash some of your remark in the |
use oasis for lib, compiler, doc, syntax, ocaml
use ocamlbuild only for toplevel,examples,tests
#40